Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context): store property missing from useStoreApi #1258

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

exuanbo
Copy link
Contributor

@exuanbo exuanbo commented Sep 3, 2022

Related Issues

Fixes #.

Summary

When the store is created with persist middleware, property storeApi.persist is missing, which does not match its type.

The internal function useBoundStore should be named as useContextStore, because the store API is not assigned to it.

Check List

  • yarn run prettier for formatting code and docs

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 00439c0:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice catch! Both are valid points. Thanks for the fixes!

@dai-shi dai-shi added this to the v4.1.2 milestone Sep 4, 2022
@himself65
Copy link
Contributor

when can this PR land?

@dai-shi
Copy link
Member

dai-shi commented Sep 6, 2022

v4.1.2 is currently planned at Sep 12.

Feel free to use the codesandbox build until then.
https://ci.codesandbox.io/status/pmndrs/zustand/pr/1258
Find "Local Install Instructions" ☝️

@dai-shi
Copy link
Member

dai-shi commented Sep 18, 2022

v4.1.2 is currently planned at Sep 12.

Sorry for the delay. We would like to merge another change, which is taking some more time.
Please use the codesandbox build meanwhile.

@dai-shi dai-shi merged commit 43ea18e into pmndrs:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants