Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added docs file for slices pattern #1344

Merged
merged 1 commit into from Oct 6, 2022

Conversation

Rec0iL99
Copy link
Contributor

@Rec0iL99 Rec0iL99 commented Oct 5, 2022

Related Issues

#1253

Summary

As per comment:

  • One dedicated page for slices in plain JS
  • A section within the TypeScript page to cover how to apply types to the slices pattern (we already have this section in the docs/guides/typescript.md file. Added a TypeScript usage link in the dedicated slices pattern document)
  • Cross-linked to each other (slice page to typescript section, and typescript section to slice page)

Check List

  • yarn run prettier for formatting code and docs

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 5, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ef03950:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

Copy link
Collaborator

@chrisk-7777 chrisk-7777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants