Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Programmatic module.exports addition for named and default exports in CJS #1460

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Fix: Programmatic module.exports addition for named and default exports in CJS #1460

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78b3088
experimental export patch
barelyhuman Dec 4, 2022
6cfc026
refactor
dai-shi Dec 5, 2022
c83b53a
add semi
dai-shi Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 15 additions & 4 deletions rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,13 @@ function createESMConfig(input, output) {
}
}

function createCommonJSConfig(input, output) {
return {
function createCommonJSConfig(input, output, options = {}) {
const config = {
input,
output: { file: `${output}.js`, format: 'cjs' },
output: {
file: `${output}.js`,
format: 'cjs',
},
external,
plugins: [
alias({
Expand All @@ -94,6 +97,12 @@ function createCommonJSConfig(input, output) {
babelPlugin(getBabelOptions({ ie: 11 })),
],
}
if (options.addModuleExport) {
config.output.outro =
'module.exports = exports.default; Object.assign(exports.default,exports)'
}

return config
}

function createUMDConfig(input, output, env) {
Expand Down Expand Up @@ -166,7 +175,9 @@ module.exports = function (args) {
}
return [
...(c === 'index' ? [createDeclarationConfig(`src/${c}.ts`, 'dist')] : []),
createCommonJSConfig(`src/${c}.ts`, `dist/${c}`),
createCommonJSConfig(`src/${c}.ts`, `dist/${c}`, {
addModuleExport: c === 'index',
dai-shi marked this conversation as resolved.
Show resolved Hide resolved
}),
createESMConfig(`src/${c}.ts`, `dist/esm/${c}.js`),
createESMConfig(`src/${c}.ts`, `dist/esm/${c}.mjs`),
createUMDConfig(`src/${c}.ts`, `dist/umd/${c}`, 'development'),
Expand Down