docs: remove now superfluous warning messages #1549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de11129:
|
1 task
sewera
suggested changes
Jan 19, 2023
There was a problem hiding this comment.
I've got only this one comment to those changes.
However, I've prepared a PR (#1559) to address all the issues I had. If you are okay with it, you can decline this PR.
I put you as a co-author of a commit with the exact changes of this PR.
| --- | ||
| title: Concepts | ||
| description: | ||
| nav: 1 |
There was a problem hiding this comment.
You've removed nav: 1 page. I suggest making comparison.md page nav: 1 instead of nav: 2.
|
Closed in favor of #1559 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Addresses #1220 and comment #1033 (reply in thread)
Summary
Removes now superfluous warning messages. With all the improvements on the docs, these messages are no longer needed.
The "concepts" page has also been dropped as there is no content and is covered by the intro page.
Check List
yarn run prettierfor formatting code and docs