Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add usage trends in readme.md #1953

Merged
merged 7 commits into from
Jul 27, 2023
Merged

add usage trends in readme.md #1953

merged 7 commits into from
Jul 27, 2023

Conversation

cwtuan
Copy link
Contributor

@cwtuan cwtuan commented Jul 24, 2023

Summary

I would like to suggest adding a link to the zustand github readme.md. This link will help developers who are choosing a state management package for React.js to compare different options based on usage trends and GitHub stars.

I use this comparison tool to keep track of the usage trend of zustand, which I have noticed is increasing over time. Additionally, zustand has the highest number of GitHub stars among all other packages listed. I believe that this information could be valuable to other developers who are searching for a reliable state management package for their React.js projects, and that zustand may be a strong contender for their needs.

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 11:58am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 24, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e221a3:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

@sewera
Copy link
Collaborator

sewera commented Jul 24, 2023

Personally, I believe everyone should pick the right tool for their project, not the most popular one. So I don't see the value here. However, it's only my opinion, maybe @dai-shi has a different one.

@sewera sewera requested a review from dai-shi July 24, 2023 09:37
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel like adding the link for comparing competitors. However, if this is ont for zustand/jotai/valtio, it might be interesting and acceptable.

@cwtuan
Copy link
Contributor Author

cwtuan commented Jul 25, 2023

Thank you for your response. I understand your point of view. I believe that providing information on usage trends and popularity can be helpful for developers making a decision on which state management package to use.

In light of your comment, would it be possible to add a link to a usage trends specifically for zustand rather than competitors? I think this would still be valuable for developers who are considering using zustand and want to see how its usage is trending over time.

Note: I have updated my commit to only include the usage trends for zustand, as per your suggestion.

readme.md Outdated
@@ -522,3 +522,4 @@ Some users may want to extend Zustand's feature set which can be done using thir
## Comparison with other libraries

- [Difference between zustand and valtio](https://github.com/pmndrs/zustand/wiki/Difference-between-zustand-and-valtio)
- [NPM package downloads trend of zustand](https://npm-compare.com/zustand/#timeRange=THREE_YEARS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's no longer a comparison.

On second thought, I don't feel like adding something about NPM downloads in readme.md.
Please consider adding it in https://docs.pmnd.rs/zustand/getting-started/comparison, and then probably comparing with other libraries that are listed in the doc makes sense.

readme.md Outdated
@@ -522,3 +522,4 @@ Some users may want to extend Zustand's feature set which can be done using thir
## Comparison with other libraries

- [Difference between zustand and valtio](https://github.com/pmndrs/zustand/wiki/Difference-between-zustand-and-valtio)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, we should fix this link. Can anyone open a PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

add link to npm trend
@cwtuan
Copy link
Contributor Author

cwtuan commented Jul 26, 2023

Thank you very much for your reply and for considering my suggestion. I appreciate your feedback and concerns. I have made the changes you suggested by fixing the comparison link in the README file and adding a NPM Downloads Trend link in the comparison.md file.

Thank you again for your time and for your willingness to work with me on this. I look forward to contributing to zustand in the future.


## Npm Downloads Trend

- [Npm Downloads Trend of State Management Libraries for React](https://npm-compare.com/react-redux,jotai,recoil,valtio/#timeRange=THREE_YEARS)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't want to include zustand? also, @reduxjs/toolkit is more comparable. what do you think?

Suggested change
- [Npm Downloads Trend of State Management Libraries for React](https://npm-compare.com/react-redux,jotai,recoil,valtio/#timeRange=THREE_YEARS)
- [Npm Downloads Trend of State Management Libraries for React](https://npm-compare.com/@reduxjs/toolkit,zustand,recoil,jotai,valtio/#timeRange=THREE_YEARS)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for overlooking the crucial addition of zustand. It has now been included in the merge request. Additionally, I agree that @reduxjs/toolkit would be a better fit for this document. Thank you for bringing it to my attention.

@@ -521,4 +521,4 @@ Some users may want to extend Zustand's feature set which can be done using thir

## Comparison with other libraries

- [Difference between zustand and valtio](https://github.com/pmndrs/zustand/wiki/Difference-between-zustand-and-valtio)
- [Difference between zustand and other state management libraries for React](https://docs.pmnd.rs/zustand/getting-started/comparison)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.
There's a CI error. Please run prettier.

@cwtuan
Copy link
Contributor Author

cwtuan commented Jul 27, 2023

CI error fixed

@dai-shi dai-shi merged commit 43791eb into pmndrs:main Jul 27, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants