-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add usage trends in readme.md #1953
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0e221a3:
|
Personally, I believe everyone should pick the right tool for their project, not the most popular one. So I don't see the value here. However, it's only my opinion, maybe @dai-shi has a different one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel like adding the link for comparing competitors. However, if this is ont for zustand/jotai/valtio, it might be interesting and acceptable.
Thank you for your response. I understand your point of view. I believe that providing information on usage trends and popularity can be helpful for developers making a decision on which state management package to use. In light of your comment, would it be possible to add a link to a usage trends specifically for zustand rather than competitors? I think this would still be valuable for developers who are considering using zustand and want to see how its usage is trending over time. Note: I have updated my commit to only include the usage trends for zustand, as per your suggestion. |
readme.md
Outdated
@@ -522,3 +522,4 @@ Some users may want to extend Zustand's feature set which can be done using thir | |||
## Comparison with other libraries | |||
|
|||
- [Difference between zustand and valtio](https://github.com/pmndrs/zustand/wiki/Difference-between-zustand-and-valtio) | |||
- [NPM package downloads trend of zustand](https://npm-compare.com/zustand/#timeRange=THREE_YEARS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it's no longer a comparison.
On second thought, I don't feel like adding something about NPM downloads in readme.md.
Please consider adding it in https://docs.pmnd.rs/zustand/getting-started/comparison, and then probably comparing with other libraries that are listed in the doc makes sense.
readme.md
Outdated
@@ -522,3 +522,4 @@ Some users may want to extend Zustand's feature set which can be done using thir | |||
## Comparison with other libraries | |||
|
|||
- [Difference between zustand and valtio](https://github.com/pmndrs/zustand/wiki/Difference-between-zustand-and-valtio) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, we should fix this link. Can anyone open a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
add link to npm trend
Thank you very much for your reply and for considering my suggestion. I appreciate your feedback and concerns. I have made the changes you suggested by fixing the comparison link in the README file and adding a NPM Downloads Trend link in the comparison.md file. Thank you again for your time and for your willingness to work with me on this. I look forward to contributing to zustand in the future. |
docs/getting-started/comparison.md
Outdated
|
||
## Npm Downloads Trend | ||
|
||
- [Npm Downloads Trend of State Management Libraries for React](https://npm-compare.com/react-redux,jotai,recoil,valtio/#timeRange=THREE_YEARS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't want to include zustand? also, @reduxjs/toolkit
is more comparable. what do you think?
- [Npm Downloads Trend of State Management Libraries for React](https://npm-compare.com/react-redux,jotai,recoil,valtio/#timeRange=THREE_YEARS) | |
- [Npm Downloads Trend of State Management Libraries for React](https://npm-compare.com/@reduxjs/toolkit,zustand,recoil,jotai,valtio/#timeRange=THREE_YEARS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies for overlooking the crucial addition of zustand
. It has now been included in the merge request. Additionally, I agree that @reduxjs/toolkit
would be a better fit for this document. Thank you for bringing it to my attention.
@@ -521,4 +521,4 @@ Some users may want to extend Zustand's feature set which can be done using thir | |||
|
|||
## Comparison with other libraries | |||
|
|||
- [Difference between zustand and valtio](https://github.com/pmndrs/zustand/wiki/Difference-between-zustand-and-valtio) | |||
- [Difference between zustand and other state management libraries for React](https://docs.pmnd.rs/zustand/getting-started/comparison) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good.
There's a CI error. Please run prettier.
CI error fixed |
Summary
I would like to suggest adding a link to the zustand github readme.md. This link will help developers who are choosing a state management package for React.js to compare different options based on usage trends and GitHub stars.
I use this comparison tool to keep track of the usage trend of zustand, which I have noticed is increasing over time. Additionally, zustand has the highest number of GitHub stars among all other packages listed. I believe that this information could be valuable to other developers who are searching for a reliable state management package for their React.js projects, and that zustand may be a strong contender for their needs.
Check List
yarn run prettier
for formatting code and docs