fix: improve warning for deprecated equalityFn #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 439a73b:
|
|
Size Change: +268 B (+1%) Total Size: 43.5 kB
ℹ️ View Unchanged
|
sewera
reviewed
Aug 5, 2023
Comment on lines
-50
to
61
| if (import.meta.env?.MODE !== 'production' && equalityFn) { | ||
| if ( | ||
| import.meta.env?.MODE !== 'production' && | ||
| equalityFn && | ||
| !didWarnAboutEqualityFn | ||
| ) { | ||
| console.warn( | ||
| "[DEPRECATED] Use `createWithEqualityFn` from 'zustand/traditional'. https://github.com/pmndrs/zustand/discussions/1937" | ||
| "[DEPRECATED] Use `createWithEqualityFn` instead of `create` or use `useStoreWithEqualityFn` instead of `useStore`. They can be imported from 'zustand/traditional'. https://github.com/pmndrs/zustand/discussions/1937" | ||
| ) | ||
| didWarnAboutEqualityFn = true | ||
| } |
There was a problem hiding this comment.
It may be a good idea to extract this to equalityFn && warnAboutEqualityFnOnce()
There was a problem hiding this comment.
Unfortunately, that doesn't work with minification/dead-code-elimination in production.
There was a problem hiding this comment.
I see, I don't have any more suggestions then.
sewera
approved these changes
Aug 6, 2023
|
I'm still waiting for some 👍 feedback in #1937. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or Discussions
#1937 (reply in thread)
#1937 (reply in thread)
#1937 (comment)
Follow-up #1945
Summary
Improve the warning message based on the feedback.
Check List
yarn run prettierfor formatting code and docs