Update export types

[dbritto-dev]

Related Issues or Discussions

Fixes #2163

Summary

The types for should be under each type of import. For instance "import", "module", "require" and "default"

Check List

• yarn run prettier for formatting code and docs

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zustand-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 2, 2023 0:51am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf044d7:

Sandbox	Source
React	Configuration
React TypeScript	Configuration
React Browserify	Configuration
React Snowpack	Configuration
React Parcel	Configuration
Next.js	Configuration
@pavlobu/zustand demo	Configuration

[dbritto-dev]

@dai-shi here you go

[dai-shi]

Related Issues or Discussions

Fixes #2164

Do you mean #2163 ?

[dbritto-dev]

Related Issues or Discussions

Fixes #2164

Do you mean #2163 ?

Yeah, that one

[dbritto-dev]

@dai-shi all yours

[dai-shi]

btw, @dbritto-dev do you understand why #2157 caused such an issue? It seems like TS picks different files for index and middleware, but I'm not sure how that could happen. It sounds like TS ignore "types" field, doesn't it?

[dbritto-dev]

btw, @dbritto-dev do you understand why #2157 caused such an issue? It seems like TS picks different files for index and middleware, but I'm not sure how that could happen. It sounds like TS ignore "types" field, doesn't it?

@dai-shi I understand the issue, in the case of inner packages when you use "types" outside of "import", "module", "require" or "default" ts use by default that types ignoring where you are importing the packages; when we added the new changes for the main package we fixed that but the inner packages still pointing to "d.ts" even if you are importing them from "esm" so that's the conflict

In a nutshell the types were always imported from *.d.ts instead of being imported from where you are importing them, like esm/*.d.ts or esm/*.d.mts. We fixed it for the main package but the inner packages needs the same change.

[dbritto-dev]

@dai-shi all yours

[dai-shi]

in the case of inner packages when you use "types" outside of "import", "module", "require" or "default" ts use by default that types ignoring where you are importing the packages;

So, the "types" line right under "exports" in v4.4.4 package.json was simply ignored? That explains it.

[dbritto-dev]

@dai-shi would you mind taking care of these changes? I tested locally and works well