Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5]: drop "module" condition #2270

Merged
merged 3 commits into from
Dec 22, 2023
Merged

[v5]: drop "module" condition #2270

merged 3 commits into from
Dec 22, 2023

Conversation

dbritto-dev
Copy link
Collaborator

Related Issues or Discussions

For #2138

Check List

  • yarn run prettier for formatting code and docs

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 4:45am

Copy link

codesandbox-ci bot commented Dec 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1dbae13:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

@dai-shi
Copy link
Member

dai-shi commented Dec 22, 2023

Thanks for working on this.
Please follow the change in pmndrs/valtio#818.
See patch-esm-ts script.

@dbritto-dev
Copy link
Collaborator Author

@dai-shi done :D

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dai-shi dai-shi merged commit f910d1c into pmndrs:v5 Dec 22, 2023
23 checks passed
@dai-shi dai-shi mentioned this pull request Dec 22, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants