Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5]: Drop getServerState #2300

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

charkour
Copy link
Collaborator

Related Issues or Discussions

For #2138

Summary

After some discussion, we will drop getServerState in v5 because it is inaccessible from the userland, and getInitialState solves the problem.

Please let me know if any updates should be made. Thank you

Check List

  • yarn run prettier for formatting code and docs

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 5:00am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 54b2b6a:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

@charkour charkour reopened this Jan 20, 2024
@charkour charkour changed the base branch from main to v5 January 20, 2024 05:00
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@dai-shi dai-shi merged commit f7c0b50 into pmndrs:v5 Jan 20, 2024
23 checks passed
@dai-shi dai-shi mentioned this pull request Jan 20, 2024
15 tasks
@charkour charkour deleted the drop-getServerState branch January 20, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants