Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5]: refactor useMemoSelector #2302

Merged
merged 4 commits into from
Jan 21, 2024
Merged

[v5]: refactor useMemoSelector #2302

merged 4 commits into from
Jan 21, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 20, 2024

for #2138

the previous version has an issue with a corner case.

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 5:07am

Copy link

codesandbox-ci bot commented Jan 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb333a9:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
@pavlobu/zustand demo Configuration

Copy link

github-actions bot commented Jan 20, 2024

Size Change: +2 B (0%)

Total Size: 9.04 kB

Filename Size Change
dist/index.js 602 B +2 B (0%)
ℹ️ View Unchanged
Filename Size
dist/middleware.js 4.08 kB
dist/middleware/immer.js 328 B
dist/react/shallow.js 1.07 kB
dist/shallow.js 1.08 kB
dist/traditional.js 464 B
dist/vanilla.js 436 B
dist/vanilla/shallow.js 969 B

compressed-size-action

@dai-shi dai-shi merged commit f8a4d58 into v5 Jan 21, 2024
22 checks passed
@dai-shi dai-shi deleted the refactor/use-memo-selector branch January 21, 2024 05:41
@charkour
Copy link
Collaborator

What was the corner case that this solved? Would it be helpful to add a test to ensure it does not regress?

@dai-shi
Copy link
Member Author

dai-shi commented Jan 22, 2024

Yes, I added: 97ff407
See also the commit history and find the test fails without the change.

@charkour
Copy link
Collaborator

Thanks!

@dai-shi dai-shi mentioned this pull request Feb 17, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants