Add T | Partial<T> to immer middleware's TS return type #2495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or Discussions
#2491
Summary
The
immer
middleware adds the capability to modify theDraft<T>
in asetState
call in-place and not return a partial state value. But the vanilla functionality of returning aT | Partial<T>
, without modifying the input state draft, is still supported and works properly.However, the
immer
middleware's type definition does not currently contain theT | Partial<T>
option and returns onlyvoid
, which can lead to invalid code compiling cleanly but wrecking the underlying store since anything is assignable tovoid
(see playground). This PR does not add any runtime JS functionality, but addsT | Partial<T>
to the immer middleware's return type, so that if you are using immer middleware and you do return a value in asetState
, that it will be type-checked.Check List
yarn run prettier
for formatting code and docs