refactor(types): prefer type alias #625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is mostly about preference, but I feel a little bad about mixing two styles for maintainability.
There are some differences between interface and type alias, like overloading, index signature and maybe others.
However, in the current code, mostly type alias is used and only some cases use interface. Hopefully making it consistent makes sense. (In this PR, to type alias.)
If this causes a real problem rather than styling preference, we can revisit. (I can think of one case, module augmentation, but wonder if anyone does it, and if it's the case, we should prefer "export function" too.)