Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix core types to better handle middleware types #641

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Nov 5, 2021

close #638
It generally improves the compatibility for pre v3.6.

@github-actions
Copy link

github-actions bot commented Nov 5, 2021

Size Change: -1 B (0%)

Total Size: 11.2 kB

Filename Size Change
dist/index.js 1.35 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
dist/context.js 622 B
dist/esm/context.js 521 B
dist/esm/index.js 1.23 kB
dist/esm/middleware.js 2.77 kB
dist/esm/shallow.js 272 B
dist/esm/vanilla.js 520 B
dist/middleware.js 2.93 kB
dist/shallow.js 318 B
dist/vanilla.js 630 B

compressed-size-action

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 893712e:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration
TypeScript (forked) Issue #638

@dai-shi
Copy link
Member Author

dai-shi commented Nov 5, 2021

https://codesandbox.io/s/typescript-forked-mgpys
@andreechristian this fixes it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist Middleware Typescript Error
1 participant