Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(middleware/devtools): remove checking old string option #933

Merged
merged 3 commits into from Apr 29, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Apr 25, 2022

This is something we forgot in #892.
Also did some refactor to remove our own options in DevtoolsOptions.

@dai-shi
Copy link
Member Author

dai-shi commented Apr 25, 2022

review request @devanshj

@github-actions
Copy link

github-actions bot commented Apr 25, 2022

Size Change: +725 B (+2%)

Total Size: 29.8 kB

Filename Size Change
dist/esm/middleware.js 3.09 kB +137 B (+5%) 🔍
dist/middleware.js 3.22 kB +149 B (+5%) 🔍
dist/system/middleware.development.js 3.18 kB +137 B (+5%) 🔍
dist/system/middleware.production.js 2.04 kB +71 B (+4%)
dist/umd/middleware.development.js 3.33 kB +150 B (+5%) 🔍
dist/umd/middleware.production.js 2.05 kB +81 B (+4%)
ℹ️ View Unchanged
Filename Size
dist/context.js 518 B
dist/esm/context.js 448 B
dist/esm/index.js 400 B
dist/esm/middleware/immer.js 210 B
dist/esm/shallow.js 272 B
dist/esm/vanilla.js 377 B
dist/index.js 642 B
dist/middleware/immer.js 373 B
dist/shallow.js 318 B
dist/system/context.development.js 572 B
dist/system/context.production.js 393 B
dist/system/index.development.js 575 B
dist/system/index.production.js 385 B
dist/system/middleware/immer.development.js 292 B
dist/system/middleware/immer.production.js 187 B
dist/system/shallow.development.js 338 B
dist/system/shallow.production.js 253 B
dist/system/vanilla.development.js 444 B
dist/system/vanilla.production.js 270 B
dist/umd/context.development.js 662 B
dist/umd/context.production.js 488 B
dist/umd/index.development.js 787 B
dist/umd/index.production.js 564 B
dist/umd/middleware/immer.development.js 514 B
dist/umd/middleware/immer.production.js 371 B
dist/umd/shallow.development.js 447 B
dist/umd/shallow.production.js 344 B
dist/umd/vanilla.development.js 590 B
dist/umd/vanilla.production.js 378 B
dist/vanilla.js 456 B

compressed-size-action

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f679bbf:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

Copy link
Contributor

@devanshj devanshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something we forgot in #892.

Ah right. LGTM.

@dai-shi dai-shi added this to the v4.0.0 milestone Apr 29, 2022
@dai-shi dai-shi merged commit 0ae0293 into main Apr 29, 2022
@dai-shi dai-shi deleted the breaking/middleware/devtools/eliminate-old-options branch April 29, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants