-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create maps-and-sets-usage.md #997
Conversation
Hi, there. I was using this lib with React and I found that there is a specific way to use Maps and Sets, so I thought that a little update could help others. What do you guys think?
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 15812d6:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. Here are some requests for clarifications and some styling preferences.
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
The size went down cause using that way there's no going wrong... Maybe it is still a good thing to have so others don't lose time like me??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more valuable if you create a codesandbox example and add a link in "Examples" section in the doc.
Agreed, should I just as an example in an existing one? |
Please create a new codesandbox and add it in Fix this too: #997 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the test. Should be good to go.
Hi, there. I was using this lib with React and I found that there is a specific way to use Maps and Sets, so I thought that a little update could help others. What do you guys think?