Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create maps-and-sets-usage.md #997

Merged
merged 7 commits into from Jul 25, 2022
Merged

Conversation

Gabriel-Alves-Cunha
Copy link
Contributor

Hi, there. I was using this lib with React and I found that there is a specific way to use Maps and Sets, so I thought that a little update could help others. What do you guys think?

Hi, there. I was using this lib with React and I found that there is a specific way to use Maps and Sets, so I thought that a little update could help others. What do you guys think?
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 15812d6:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Here are some requests for clarifications and some styling preferences.

docs/maps-and-sets-usage.md Outdated Show resolved Hide resolved
docs/maps-and-sets-usage.md Outdated Show resolved Hide resolved
docs/maps-and-sets-usage.md Outdated Show resolved Hide resolved
docs/maps-and-sets-usage.md Outdated Show resolved Hide resolved
Gabriel-Alves-Cunha and others added 2 commits June 8, 2022 18:37
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
The size went down cause using that way there's no going wrong...
Maybe it is still a good thing to have so others don't lose time like me??
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more valuable if you create a codesandbox example and add a link in "Examples" section in the doc.

docs/maps-and-sets-usage.md Outdated Show resolved Hide resolved
@Gabriel-Alves-Cunha
Copy link
Contributor Author

I think it's more valuable if you create a codesandbox example and add a link in "Examples" section in the doc.

Agreed, should I just as an example in an existing one?

@dai-shi
Copy link
Member

dai-shi commented Jun 14, 2022

Please create a new codesandbox and add it in docs/maps-and-sets-usage.md.

Fix this too: #997 (comment)

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the test. Should be good to go.

@dai-shi dai-shi merged commit da15804 into pmndrs:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants