Fix operator precedence. #2730
Merged
Fix operator precedence. #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug was discovered when enabling failed image support (part of the Fortran 2015 standard) in the OpenCoarrays project: sourceryinstitute/OpenCoarrays#439 |
The precedence of [] is higher than *. I.e. *bitarray[i] means to first deref by the index i and the pointer, but needed here is to first deref the pointer and then the array. Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov>
raffenet
force-pushed
the
fix_precedence
branch
from
a29002a
to
498fe63
Compare
|
Looks good to me. Thanks! |
|
Will this patch make it into the next release? Is there a target release date for the next stable release? Cheers. |
|
@ilovezfs @fxcoudert @MikeMcQuaid would a patch for this be accepted to the @Homebrew formula for MPICH until this makes it into the next release? |
|
@zbeekman We try to patch as little as possible, restricting ourselves to a) security fixes, b) build failures, c) high-impact bugs that affect a large fraction of our users. I suggest you simply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precedence of [] is higher than *. I.e. *bitarray[i] means to first
deref by the index i and the pointer, but needed here is to first deref
the pointer and then the array.