New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submodule revert #2851
Submodule revert #2851
Conversation
test:jenkins/ch3/tcp |
echo "########################################################" | ||
echo | ||
|
||
if test ! -e "src/mpl/confdb/aclocal.m4" ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this need to be changed to check for hwloc
rather than being removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that should go in Hydra's autogen.sh
. There is no hwloc
in MPICH yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, on second thought, it could probably go here.
Since |
Can you add those commits onto this branch? |
Sure. I can add them right now. |
@raffenet Added two commit: Fix F08 and add hwloc as a submodule. You might run into some conflict when rebasing, do a |
test:jenkins/ch3/tcp |
hwloc submodule is not working. |
dd246b6
to
48ea7ce
Compare
test:jenkins/ch3/tcp |
I picked wrong version. Now it should work. |
@wesbland no, those aren't in this PR. I will add them now. |
48ea7ce
to
498f8ac
Compare
test:jenkins/ch3/tcp @wesbland the |
498f8ac
to
1fd4f92
Compare
test:jenkins/ch3/tcp |
Yep. That's true. |
@yfguo test builds look good so far. I'd like to get this merged sooner rather than later so we can move on to other PRs. What do you think? |
I agree. I can signoff and merge. |
This reverts commit a7ac6e8. Signed-off-by: Yanfei Guo <yguo@anl.gov>
This reverts commit e61b7f9. Signed-off-by: Yanfei Guo <yguo@anl.gov>
This reverts commit 90df096. Signed-off-by: Yanfei Guo <yguo@anl.gov>
This reverts commit 0e8d809. Signed-off-by: Yanfei Guo <yguo@anl.gov>
This reverts commit 93f6f8e. Signed-off-by: Yanfei Guo <yguo@anl.gov>
The new check is for the case where a async subarray is passed to a assumed-type assumed-rank async dummy argument of a interface in a module. ifort 18 is known to give compile error on it. This is a patch to confdb after the switching to submodule. Here is to bring it back. Signed-off-by: Yanfei Guo <yguo@anl.gov>
Signed-off-by: Yanfei Guo <yguo@anl.gov>
Adds supports for Argobots thread interface, including: creation, lock/unlock, yielding and condition. Argobots can be enabled by using --with-thread-package=argobots This commit takes the final codes from mpich-dev/mpi-argobots branch without preserving its detail history. The original contributors are Halim Amer, Pavan Balaji, Huiwei Lu and Sangmin Seo. Signed-off-by: Ken Raffenetti <raffenet@mcs.anl.gov> Signed-off-by: Yanfei Guo <yguo@anl.gov>
1fd4f92
to
d3be64b
Compare
Revert confdb, mpl and hydra as submodules back to in-repo source.