Fix build errors on MacOs #3800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The (case-sensitive) automake macro HAVE_HWLOC was previously added in the top level configure.ac to be able to detect when HWLOC was enabled to help determine when to build topology-aware trees in CH4. However, just knowing if HWLOC was available was actually not enough. The Linux-only header, sched.h, is also needed to be able to use the needed features in HWLOC. This became apparent when trying to build on MacOS, which doesn't have this header. So this patch moves the check down to CH4 (because that's the only place where it's used) and adds a check to see if the needed features of sched.h are available. Thus the new macro is called BUILD_TOPOTREES instead of HAVE_HWLOC. Then, this patch changes the ch4/shm makefile to check this macro before building the topology aware trees code.
Not initialzing it to -1 was exposing some bugs when hwloc is not present.
|
test:jenkins/ch4/most |
|
Looks fine to me as long as tests pass. |
yfguo
requested changes
May 23, 2019
yfguo
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes the build issues on MacOs which were caused due to Intra-node Topology aware trees.
The Linux-only header, sched.h, is also needed to be able to use the needed features in HWLOC.
Expected Performance Changes
Known Issues
Author Checklist
module: short descriptionand follows good practicedoc/directory for any new code design