config: replace ax_prefix_config_h.m4

[hzhou]

Replace AX_PREFIX_CONFIG_H with AC_CONFIG_COMMANDS and
perl confdb/cmd_prefix_config_h.pl.

Expected Performance Changes

Known Issues

Author Checklist

• Reference appropriate issues (with "Fixes" or "See" as appropriate)
• Confirm whitespace/style checkers are happy (or has a good reason for being bad)
• Commits are self-contained and do not do two things at once
• Remove xfail from the test suite when fixing a test
• Commit message is of the form: module: short description and follows good practice
• Add comments such that someone without knowledge of the code could understand
• Add Devel Docs in the doc/ directory for any new code design
• Passes tests (included warning check)

[hzhou]

test:mpich/custom
env: skip_test=true

[hzhou]

test:jenkins/ch3/tcp

[raffenet]

The defines here (https://github.com/pmodels/mpich/blob/master/src/mpl/configure.ac#L816) get double prefixed after this patch, and may not work as intended. I wonder if this even worked before this patch...

[hzhou]

The defines here (https://github.com/pmodels/mpich/blob/master/src/mpl/configure.ac#L816) get double prefixed after this patch, and may not work as intended. I wonder if this even worked before this patch...

I'll fix the script to detect and avoid double prefix.

[hzhou]

Added another commit to

• avoid double prefix
• add prefix to the #undef inside comments
• direct define, matches AC_CONFIG_HEADER, deviates from AX_PREFIX_CONFIG_H

retest:
test:jenkins/ch4/most
test:jenkins/ch3/most

[raffenet]

Looking better. I'm still seeing a few issues. I don't think this is actually a problem, but looks a little weird.

/* Define to 1 if on MINIX. /
/ #undef _mpl__MINIX */

/* Define to 2 if the system does not provide POSIX.1 features except with
this defined. /
/ #undef _mpl__POSIX_1_SOURCE */

/* Define to 1 if you need to in order for `stat' and other things to work. /
/ #undef _mpl__POSIX_SOURCE */

[hzhou]

Looking better. I'm still seeing a few issues. I don't think this is actually a problem, but looks a little weird.

/* Define to 1 if on MINIX. /
/ #undef _mpl__MINIX /
/ Define to 2 if the system does not provide POSIX.1 features except with
this defined. /
/ #undef _mpl__POSIX_1_SOURCE /
/ Define to 1 if you need to in order for `stat' and other things to work. /
/ #undef _mpl__POSIX_SOURCE */

That was AX_PREFIX_CONFIG_H's behavior, it prefixes _mpl_ when the symbol starts with non-capital. In those case, it starts with _. We don't have to do that. In fact, I much prefer just always prefix MPL_.

[hzhou]

Actually, I am not sure what AX_PREFIX_CONFIG_H for the likes of _MINIX, maybe that is treated as all capitals. Anyway, how about always use MPL_ prefix regardless of the symbol case?

[raffenet]

Here is what it did previously.

/* Define to 1 if on MINIX. /
/ #undef _MINIX */

/* Define to 2 if the system does not provide POSIX.1 features except with
this defined. /
/ #undef _POSIX_1_SOURCE */

/* Define to 1 if you need to in order for `stat' and other things to work. /
/ #undef _POSIX_SOURCE */

I don't have much opinion about always using upper-case. We just need to make sure to update all the places in the code that used the old style.

[hzhou]

Here is what it did previously.

Previously, AX_PREFIX_CONFIG_H doesn't touch symbols in the comment (#undef). I'll update the script to always use uppercase prefix.

[hzhou]

On second thought, it is better to conform to the convention AX_PREFIX_CONFIG_H. openpa in particular uses _opa_inline all over, it doesn't make sense to bring too much diffs.

I patched the script so it applies MPL_ when the whole symbol is upper case (including _), otherwise, it applies _mpl_.

test:jenkins/ch3/most
test:jenkins/ch4/most

[hzhou]

Actually, for inline, const, and restrict, it is really best to leave them alone (without adding prefix) so the code can use the keyword directly. We can add #ifndef inline guard so it is still safe to #include opa_config.h on top of mpichconf.h or mplconf.h.

I'll add another commit to test it out.

[hzhou]

test:jenkins/ch3/most
test:jenkins/ch4/most

[hzhou]

test:mpich/quick
skip_test: true

[hzhou]

ROMIO still have the MPI_OFFSET warnings, disable it and retest:

test:mpich/quick --with-device=ch4:ofi --disable-romio
testlist: coll/allred 4

[hzhou]

@raffenet This PR is ready for your another review.

[raffenet]

Perhaps we should remove usage of autoconf macros for const, restrict, and inline as well and just assume they are available? https://github.com/pmodels/mpich/blob/master/src/mpl/configure.ac#L52

I still see some weird stuff in mplconfig.h, but only for commented lines, so maybe it doesn't matter.

/* Define to 1 if on MINIX. /
/ #undef MPL__MINIX */

/* Define to 2 if the system does not provide POSIX.1 features except with
this defined. /
/ #undef _mpl__POSIX_1_SOURCE */

/* Define to 1 if you need to in order for `stat' and other things to work. /
/ #undef MPL__POSIX_SOURCE */

and

/* Define which x86 cycle counter to use /
/ #undef _mpl_LINUX86_CYCLE_CPUID_RDTSC32 */

/* Define which x86 cycle counter to use /
/ #undef _mpl_LINUX86_CYCLE_CPUID_RDTSC64 */

/* Define which x86 cycle counter to use /
/ #undef _mpl_LINUX86_CYCLE_RDTSC */

/* Define which x86 cycle counter to use /
/ #undef _mpl_LINUX86_CYCLE_RDTSCP */

[hzhou]

Perhaps we should remove usage of autoconf macros for const, restrict, and inline as well and just assume they are available? https://github.com/pmodels/mpich/blob/master/src/mpl/configure.ac#L52

I saw that restrict gets defined as __restrict, so maybe gcc in default mode doesn't support restrict?

I still see some weird stuff in mplconfig.h, but only for commented lines, so maybe it doesn't matter.

/* Define to 1 if on MINIX. /
/ #undef MPL__MINIX /
/ Define to 2 if the system does not provide POSIX.1 features except with
this defined. /
/ #undef _mpl__POSIX_1_SOURCE /
/ Define to 1 if you need to in order for `stat' and other things to work. /
/ #undef MPL__POSIX_SOURCE */

and

/* Define which x86 cycle counter to use /
/ #undef _mpl_LINUX86_CYCLE_CPUID_RDTSC32 /
/ Define which x86 cycle counter to use /
/ #undef _mpl_LINUX86_CYCLE_CPUID_RDTSC64 /
/ Define which x86 cycle counter to use /
/ #undef _mpl_LINUX86_CYCLE_RDTSC /
/ Define which x86 cycle counter to use /
/ #undef _mpl_LINUX86_CYCLE_RDTSCP */

Ahh... numbers. I'll fix it. One thing for rolling our own is lack of testing, but we are getting there...

[hzhou]

test:jenkins/ch3/most
test:jenkins/ch4/most

[hzhou]

test:jenkins/ch4/most

[raffenet]

I'm confused why these values get prefixed:

/* Define to 1 if on MINIX. */
/* #undef MPL__MINIX */

/* Define to 2 if the system does not provide POSIX.1 features except with
   this defined. */
/* #undef MPL__POSIX_1_SOURCE */

/* Define to 1 if you need to in order for `stat' and other things to work. */
/* #undef MPL__POSIX_SOURCE */

while these do not:

/* Enable extensions on AIX 3, Interix.  */
#ifndef _ALL_SOURCE
# define _ALL_SOURCE 1
#endif
/* Enable GNU extensions on systems that have them.  */
#ifndef _GNU_SOURCE
# define _GNU_SOURCE 1
#endif
/* Enable threading extensions on Solaris.  */
#ifndef _POSIX_PTHREAD_SEMANTICS
# define _POSIX_PTHREAD_SEMANTICS 1
#endif
/* Enable extensions on HP NonStop.  */
#ifndef _TANDEM_SOURCE
# define _TANDEM_SOURCE 1
#endif
/* Enable general extensions on Solaris.  */
#ifndef __EXTENSIONS__
# define __EXTENSIONS__ 1
#endif

[hzhou]

I'm confused why these values get prefixed:

/* Define to 1 if on MINIX. */
/* #undef MPL__MINIX */

while these do not:

/* Enable extensions on AIX 3, Interix.  */
#ifndef _ALL_SOURCE
# define _ALL_SOURCE 1
#endif

Because they are of different patterns from those generated by AC_DEFINE (notice the space between # and define). I believe AX_PREFIX_CONFIG_H doesn't touch them either. These macros (_ALL_SOURCE, ...) are not used by our code; rather they are directives for C compiler; they won't work if we add prefix.

ref: AC_USE_SYSTEM_EXTENSIONS

[hzhou]

Oh, I see. What you meant was that we shouldn't touch _MINIX, _POSIX_1_SOURCE, and _POSIX_SOURCE either?

I could modify the scripts to exempt macros start with _, just like how it did with inline, const and restrict.

[hzhou]

test:jenkins/ch3/sock

[raffenet]

Output from this one looks good. I'm going to merge.