Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpi/coll: Add generic vertex type in gentran scheduler #3872

Merged
merged 1 commit into from Jun 27, 2019
Merged

mpi/coll: Add generic vertex type in gentran scheduler #3872

merged 1 commit into from Jun 27, 2019

Conversation

zhenggb72
Copy link
Contributor

Add Gentran API to register a generic vertex type, which enables composite schedulers.

Pull Request Description

Expected Performance Changes

Known Issues

Author Checklist

  • Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • Passes tests (included warning check)
  • Confirm whitespace/style checkers are happy (or has a good reason for being bad)
  • Commits are self-contained and do not do two things at once
  • Remove xfail from the test suite when fixing a test
  • Commit message is of the form: module: short description and follows good practice
  • Add comments such that someone without knowledge of the code could understand
  • Add Devel Docs in the doc/ directory for any new code design

@hzhou hzhou self-assigned this Jun 26, 2019
hzhou
hzhou requested changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@hzhou hzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks straightforward. Just remove the #FCNAME cruft, Add commit message (and PR description) of its purpose (don't need to be long), and we'll commit it as long as it doesn't break the build.

src/mpi/coll/transports/gentran/tsp_gentran.c Show resolved Hide resolved
src/mpi/coll/transports/gentran/tsp_gentran.c Show resolved Hide resolved
src/mpi/coll/transports/gentran/tsp_gentran.c Outdated Show resolved Hide resolved
src/mpi/coll/transports/gentran/tsp_gentran.c Outdated Show resolved Hide resolved
@zhenggb72
mpi/coll: Add generic vertex type in gentran scheduler
af753ca 
Add API to register a generic vertex type. This allows other modules
for example in the device layer to extend gentran scheduler for
their operations.
@hzhou
Copy link
Contributor

hzhou commented Jun 26, 2019

test:jenkins/ch4/ucx
test:jenkins/ch3/tcp
test:mpich/warnings

@zhenggb72
Copy link
Contributor Author

There are some test failure, but looks like due to other known issue?

@hzhou hzhou merged commit a522634 into pmodels:master Jun 27, 2019
@hzhou hzhou mentioned this pull request Jun 20, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzhou hzhou hzhou approved these changes

Assignees

@hzhou hzhou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhenggb72 @hzhou