Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpl/ze: Fix IPC memory flags #5623

Merged
merged 1 commit into from
Oct 27, 2021
Merged

mpl/ze: Fix IPC memory flags #5623

merged 1 commit into from
Oct 27, 2021

Conversation

raffenet
Copy link
Contributor

@raffenet raffenet commented Oct 27, 2021

Pull Request Description

ZE_IPC_MEMORY_FLAG_TBD is no longer listed as flag in the Level Zero
documentation. The zeMemOpenIpcHandle documentation states that 0 is the
default memory flag, so just use that. See nwchemgit/nwchem#463.

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

Copy link
Contributor

@hzhou hzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raffenet
Copy link
Contributor Author

I compile tested this with the latest Level Zero. Existing main did not build without this patch. Going to merge since there's no other test configuration at the moment.

ZE_IPC_MEMORY_FLAG_TBD is no longer listed as a valid flag in the Level
Zero documentation. The zeMemOpenIpcHandle documentation states that 0
is the default, so just use that. See nwchemgit/nwchem#463.
@raffenet raffenet merged commit 8c779ac into pmodels:main Oct 27, 2021
@raffenet raffenet deleted the ze-ipc-fix branch October 27, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants