[4.1.x] another batch of fixes #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the statuses parameter can accept MPI_STATUSES_IGNORE, we need use pointer rather than array, or the modern compiler may complain.
Add a call to CFI_is_contiguous, which is needed by the f08 binding. Some compilers provide this prototype, but not the symbol, so we need to disable f08 if the test fails to link. Fixes pmodels#6505
Return an accurate error message to the user when they try to cancel an inactive persistent send or recv request. Closes pmodels#6542.
We should retry the fi_rectmsg if it returns -FI_EAGAIN.
Add a patch to disable an error message from the psm3 provider in builds with --disable-shared. Fixes pmodels#6518.
We need to handle the case where a non-zero root uses MPI_IN_PLACE. Otherwise we could try reading from a bad address and crash. Fixes pmodels#6540. NOTE: For single node reduce operation with non-zero root, this composition incurs an extra copy from rank 0->root.
This test checks whether MPI_Allreduce produce identical results on all ranks with floating point datatype.
The ranks should be already in order from MPII_Recexchalgo_get_neighbors.
If the basic datatype is a floating point, we need make sure to do the local reduction following the same associativity on all ranks, or different rank will result in non-identical results due to rounding.
|
test:mpich/ch4/most |
|
Ignoring multinic failure in testing. Ready for review. |
That failure now appears quite frequent. I'll investigate at sometime. |
There's some multinic fixes in main that haven't been backported to 4.1.x. Since its an opt-in feature I think we can safely ignore for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix a handful of user-reported issues.
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.