hydra: slurm hostlist_t should be used as pointer #6820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raffenet
approved these changes
Nov 29, 2023
Appears Slurm changed the signature and usage of its hostlist function and hostlist_t type. `hostlist_t` is an opaque struct, and should be used in its pointer form.
hzhou
force-pushed
the
2311_slurm_hostlist_t
branch
from
05bae97
to
7a28682
Compare
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Dec 18, 2023
See <pmodels/mpich#6806>. Patch from <pmodels/mpich#6820>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
It appears Slurm changed the signature and usage of its hostlist function and hostlist_t type.
hostlist_tis an opaque struct, and should be used in its pointer form.Fixes #6806
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.