Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMI: allow user to override PMI key value length #7009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PMI: allow user to override PMI key value length #7009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/util/mpir_pmi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ int MPIR_pmi_init(void)
mpi_errno = pmix_init(&has_parent, &rank, &size, &appnum));
MPIR_ERR_CHECK(mpi_errno);

/* allowing user to override default KEY VAL size for certain system setups */
MPL_env2int("PMI_MAX_KEY_SIZE", &pmi_max_key_size);
MPL_env2int("PMI_MAX_VAL_SIZE", &pmi_max_val_size);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is question whether this is the true cause of the issue. Let's hold the PR until we understand better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, describe the actual changes in the commit message. The issue number is not github specific and not safe for downstreams.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yfguo Please refer to #6924 (comment)

unsigned world_id = 0;
if (pmi_kvs_name) {
HASH_FNV(pmi_kvs_name, strlen(pmi_kvs_name), world_id);
Expand Down