First draft of paper slips #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmourlanne
reviewed
Apr 30, 2023
| @@ -50,5 +51,24 @@ def home(): | |||
| ) | |||
| rows = sorted(rows, key=lambda row: row["player_1"].lower()) | |||
| return render_template("pairings.html", rows=rows, **ctx) | |||
| elif request.form["action"] == "match_slips": | |||
There was a problem hiding this comment.
Nitpick: You don't need an elif and could do with an if, since we return in the block above
|
|
||
| rows = [] | ||
| for pairing in pairings: | ||
| # We want to display each pairing twice, once for each player |
There was a problem hiding this comment.
This comment can go (I imagine it was copy pasted)
| "player_2_points": pairing.player_2.points, | ||
| }, | ||
| ) | ||
| rows = sorted(rows, key=lambda row: row["player_1"].lower()) |
There was a problem hiding this comment.
Probably want to order by table number, and do some neat things with modulo to ease up the cutting
| rows = sorted(rows, key=lambda row: row["player_1"].lower()) | ||
| now = datetime.now() | ||
| date = now.strftime("%d/%m/%Y") | ||
| return render_template("paper_slips.html", date=date, rows=rows, **ctx) |
There was a problem hiding this comment.
Suggested change
| return render_template("paper_slips.html", date=date, rows=rows, **ctx) | |
| return render_template("match_slips.html", date=date, rows=rows, **ctx) |
Let's be consistent with the naming
Comment on lines
+70
to
+71
| now = datetime.now() | ||
| date = now.strftime("%d/%m/%Y") |
There was a problem hiding this comment.
- There's a
datetime.datelibrary which lets you manipulate dates without time, which is probably what you want to do here - Because of this,
dateis more or less a reserved name :>
Something like this should work:
Suggested change
| now = datetime.now() | |
| date = now.strftime("%d/%m/%Y") | |
| from datetime import date | |
| today_str = date.today().strftime("%d/%m/%Y") |
|
|
||
| <div class="row paper-slip__p2-infos"> | ||
| <div class="col-6"> | ||
| Player 1: {{ row["player_2"] }}<br> |
There was a problem hiding this comment.
Suggested change
| Player 1: {{ row["player_2"] }}<br> | |
| Player 2: {{ row["player_2"] }}<br> |
| border-bottom: 2px solid black; | ||
| height: 100%; | ||
| } | ||
| @media print { |
There was a problem hiding this comment.
I'll have a look, I'm surprised we need all of this custom CSS for print, whereas I didn't need anything for the pairings / standings (?)
|
Closing in favour of #14 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6