Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure for zlib-ng 2.1.2 #24

Closed
pmqs opened this issue Jun 8, 2023 · 9 comments
Closed

Build failure for zlib-ng 2.1.2 #24

pmqs opened this issue Jun 8, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@pmqs
Copy link
Owner

pmqs commented Jun 8, 2023

https://github.com/pmqs/Compress-Raw-Zlib/actions/runs/5204824941/jobs/9389538386

"/opt/hostedtoolcache/perl/5.36.1/x64/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- Zlib.bs blib/arch/auto/Compress/Raw/Zlib/Zlib.bs 644
"/opt/hostedtoolcache/perl/5.36.1/x64/bin/perl" "/opt/hostedtoolcache/perl/5.36.1/x64/lib/5.36.1/ExtUtils/xsubpp"  -typemap '/opt/hostedtoolcache/perl/5.36.1/x64/lib/5.36.1/ExtUtils/typemap' -typemap '/home/runner/work/Compress-Raw-Zlib/Compress-Raw-Zlib/typemap'  Zlib.xs > Zlib.xsc
mv Zlib.xsc Zlib.c
cc -c  -I/home/runner/upstream-zlib-install-develop/include -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2   -DVERSION=\"2.204\" -DXS_VERSION=\"2.204\" -fPIC "-I/opt/hostedtoolcache/perl/5.36.1/x64/lib/5.36.1/x86_64-linux/CORE"  -DNO_VIZ      -DGZIP_OS_CODE=3 -DUSE_PPPORT_H -DPerl_crz_BUILD_ZLIB=0 Zlib.c
In file included from Zlib.xs:37:
constants.h: In function ‘constant’:
/home/runner/upstream-zlib-install-develop/include/zlib.h:57:27: error: ‘F’ undeclared (first use in this function); did you mean ‘OF’?
   57 | #define ZLIBNG_VER_STATUS F         /* 0=devel, 1-E=beta, F=Release */
      |                           ^
constants.h:580:20: note: in expansion of macro ‘ZLIBNG_VER_STATUS’
  580 |       *iv_return = ZLIBNG_VER_STATUS;
      |                    ^~~~~~~~~~~~~~~~~
/home/runner/upstream-zlib-install-develop/include/zlib.h:57:27: note: each undeclared identifier is reported only once for each function it appears in
   57 | #define ZLIBNG_VER_STATUS F         /* 0=devel, 1-E=beta, F=Release */
      |                           ^
constants.h:580:20: note: in expansion of macro ‘ZLIBNG_VER_STATUS’
  580 |       *iv_return = ZLIBNG_VER_STATUS;
      |                    ^~~~~~~~~~~~~~~~~
make: *** [Makefile:[34](https://github.com/pmqs/Compress-Raw-Zlib/actions/runs/5204824941/jobs/9389538386#step:9:35)8: Zlib.o] Error 1
Error: Process completed with exit code 2.
@pmqs pmqs added the bug Something isn't working label Jun 8, 2023
@pmqs pmqs self-assigned this Jun 8, 2023
@pmqs
Copy link
Owner Author

pmqs commented Jun 8, 2023

Root cause is in Makefile.PL -- the constant ZLIBNG_VER_STATUS is assumed to be an integer. zlib-ng documents the macro as

#define ZLIBNG_VER_STATUS F         /* 0=devel, 1-E=beta, F=Release */

@todd-richmond
Copy link

This patch works for me w/ zlib-ng 2.1.3. Please post a new CPAN release

@pmqs
Copy link
Owner Author

pmqs commented Jun 30, 2023

It's in the works @todd-richmond. Need to deal with a MacOS failure first.

@kloczek
Copy link

kloczek commented Jul 15, 2023

Any update about fix of that issue? 🤔
BTW it looks like the same issue is in perl 5.38.1.

@pmqs
Copy link
Owner Author

pmqs commented Jul 15, 2023

Hey @kloczek, thanks for the ping. Will try to get it done this week.

@jkeenan
Copy link

jkeenan commented Jul 15, 2023

Hey @kloczek, thanks for the ping. Will try to get it done this week.

Also reported in the Perl 5 core distribution's bug queue at:
Perl/perl5#21238

@pmqs
Copy link
Owner Author

pmqs commented Jul 15, 2023

Hey @kloczek, thanks for the ping. Will try to get it done this week.

Also reported in the Perl 5 core distribution's bug queue at: Perl/perl5#21238

Thanks, wasn't aware of the Perl 5 issue

@pmqs
Copy link
Owner Author

pmqs commented Jul 16, 2023

version 2.205 just uploaded to CPAN with the fix for this issue.

@pmqs pmqs closed this as completed Jul 16, 2023
@kloczek
Copy link

kloczek commented Jul 17, 2023

Tested new version and looks like issue has been solved.
Thank you 👍

jkeenan added a commit to Perl/perl5 that referenced this issue Jul 19, 2023
  2.205 16 July 2023

      * 2.205
        Sun, 16 Jul 2023 16:11:31 +0100
        3effdb9dbaa9bedfff3cad44902e515409ffae78

      * Test::More::isn't warns in perl 5.38
        Sun, 9 Jul 2023 21:38:15 +0100
        928bbc6ddc5178621fb477b38a1b4b4de38866cf

      * add zlib-ng 2.1.3
        Thu, 29 Jun 2023 19:51:58 +0100
        b1aa2583b4c114c2194890a0e015fdc439928c31

      * add zlib-ng 2.1.2
        Fri, 9 Jun 2023 14:51:17 +0100
        0d505d9156ca7e9cac15e2d6e574099300f91a14

      * Change storage of ZLIBNG_VER_STATUS from IV to PV pmqs/Compress-Raw-Zlib#24
        Fri, 9 Jun 2023 14:30:36 +0100
        0a8fb7141a43b8e49609fb06f05fad5150a97c2a

      * Fix to allow building with C++17 register keyword not allowed in C++17 pmqs/Compress-Raw-Zlib#23
        Mon, 22 May 2023 12:42:51 +0100
        a7c12acdd4ce7fdc070f50ac78e68e04c8699c81

      * Change while loop for `LimitOutput`  example pmqs/Compress-Raw-Zlib#21
        Sun, 21 May 2023 21:32:19 +0100
        972f03b5b0bf06d44991bbee2d2c9216e4175154

      * [doc] zlib.h: Remove duplicate "the" (#22)
        Mon, 1 May 2023 22:46:39 +0200
        89b43e6978d8e9b16801f48881cadf822585be0d

      * Add zlib compat version for 2.0.7
        Sat, 18 Mar 2023 08:42:59 +0000
        e7d79cbd5924fbdcd3515fb3b0ad171c7720105c
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Aug 1, 2023
Changelog:
===========
* drop rt.cpan from SUPPORT section
* Test::More::isn't warns in perl 5.38
* add zlib-ng 2.1.3
* add zlib-ng 2.1.2
* Change storage of ZLIBNG_VER_STATUS from IV to PV pmqs/Compress-Raw-Zlib#24
* Fix to allow building with C++17 register keyword not allowed in C++17 pmqs/Compress-Raw-Zlib#23
* Change while loop for `LimitOutput`  example pmqs/Compress-Raw-Zlib#21
* [doc] zlib.h: Remove duplicate "the" (openembedded#22)
* Add zlib compat version for 2.0.7

Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants