Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom mapfs.yaml in asset stack #1170

Open
bates64 opened this issue Feb 7, 2024 · 2 comments
Open

Support custom mapfs.yaml in asset stack #1170

bates64 opened this issue Feb 7, 2024 · 2 comments
Labels
asset Relates to a particular asset in the build graph build system Relates to build system internals like configure.py

Comments

@bates64
Copy link
Member

bates64 commented Feb 7, 2024

Removing an asset from mapfs.yaml breaks splitting due to the self.files.get(name) is not None assertion. Ideally asset stacks should declare mapfs.yaml that overrides this one, and the one in splat_ext is used only for splitting. It should probably be in ver, too

@bates64 bates64 added asset Relates to a particular asset in the build graph build system Relates to build system internals like configure.py labels Feb 7, 2024
@bates64
Copy link
Member Author

bates64 commented Feb 16, 2024

So we would have an assets/us/mapfs/mapfs.yaml

@bates64
Copy link
Member Author

bates64 commented Feb 16, 2024

OK, implementing the above comment introduces the problem of not being able to remove things from the mapfs. But I think that's okay, if we later do more modular asset directories e.g.

assets/
  core
  us
  jp
  pal
  ique
  prologue
  chapter1
  chapter2

This is valuable for romhacks. However it will need its own separate issue because we will need some way for splat to split to multiple directories!

bates64 added a commit that referenced this issue Feb 16, 2024
ethteck pushed a commit that referenced this issue Feb 16, 2024
* add old star rod dirs to gitignore

* remove something from mapfs to introduce bug

* fix build

See #1170

* Revert "remove something from mapfs to introduce bug"

This reverts commit 4a39278.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset Relates to a particular asset in the build graph build system Relates to build system internals like configure.py
Projects
None yet
Development

No branches or pull requests

1 participant