-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings #366
Labels
good first issue
Good for newcomers
Comments
We should remove |
bates64
added a commit
that referenced
this issue
Aug 18, 2021
* generate permuter_settings.toml * remove -Wshadow (#366) Co-authored-by: pixel-stuck <mathmcclintic@gmail.com>
I think this can be closed now. We've severely reduced the number of warnings and continue to do so |
Gonna close, but someone can re-open if they disagree. I mostly think this is moot cause it was made before the warning check system / Bowser Slug entered the fray |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Compiling the rom emits a ton of warnings that we should be able to fix - mostly implicit casts that should really be made explicit.
Additionally it would be nice to be able to enable
-Wimplicit -Wredundant-decls
so headers are used properly.Once this is done we can enable![:shipit: :shipit:](https://github.githubassets.com/images/icons/emoji/shipit.png)
-Werror
on Jenkins so people fix their warnings as they match stuffThe text was updated successfully, but these errors were encountered: