Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #366

Closed
bates64 opened this issue Aug 16, 2021 · 3 comments
Closed

Fix warnings #366

bates64 opened this issue Aug 16, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@bates64
Copy link
Member

bates64 commented Aug 16, 2021 •
edited

Compiling the rom emits a ton of warnings that we should be able to fix - mostly implicit casts that should really be made explicit.
Additionally it would be nice to be able to enable -Wimplicit -Wredundant-decls so headers are used properly.

Once this is done we can enable -Werror on Jenkins so people fix their warnings as they match stuff :shipit:
@bates64 bates64 added the good first issue Good for newcomers label Aug 16, 2021
@bates64
Copy link
Member Author

bates64 commented Aug 17, 2021

We should remove -Wshadow entirely because the DL-building macros emit warning: declaration of _g' shadows previous local`

@bates64 bates64 mentioned this issue Aug 18, 2021
Open
bates64 added a commit that referenced this issue Aug 18, 2021
@bates64
remove -Wshadow (#366)
45f7f76
bates64 added a commit that referenced this issue Aug 18, 2021
@bates64 @pixel-stuck
hud_element.c (#371)
49bee85 
* generate permuter_settings.toml
* remove -Wshadow (#366)

Co-authored-by: pixel-stuck <mathmcclintic@gmail.com>
@bates64 bates64 mentioned this issue Aug 23, 2021
Merged
@Brotenko Brotenko self-assigned this Nov 11, 2021
@Brotenko Brotenko removed their assignment Nov 22, 2021
@ethteck
Copy link
Member

ethteck commented Mar 5, 2022

I think this can be closed now. We've severely reduced the number of warnings and continue to do so

@ethteck
Copy link
Member

ethteck commented Mar 5, 2022

Gonna close, but someone can re-open if they disagree. I mostly think this is moot cause it was made before the warning check system / Bowser Slug entered the fray

@ethteck ethteck closed this as completed Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ethteck @bates64 @Brotenko