Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add port and config parameters #5

Merged
merged 6 commits into from
Jan 29, 2020
Merged

add port and config parameters #5

merged 6 commits into from
Jan 29, 2020

Conversation

gko
Copy link
Contributor

@gko gko commented Jan 28, 2020

closes #4

@gko gko marked this pull request as ready for review January 28, 2020 03:51
@gko gko requested a review from tkrotoff January 28, 2020 03:51
tkrotoff
tkrotoff requested changes Jan 28, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@tkrotoff
Copy link
Collaborator

I've added a new branch test-bin/stub-server: https://github.com/pmu-tech/stub-server/tree/test-bin/stub-server

It tests bin/stub-server, to be reviewed and merged after this branch has been merged.

@tkrotoff
Copy link
Collaborator

README.md should also be updated: https://github.com/pmu-tech/stub-server/blob/fc83b29b3025d0ff8840fda714fd96a1c54bf781/README.md#command-line

@gko
Copy link
Contributor Author

gko commented Jan 29, 2020

I've added a new branch test-bin/stub-server: https://github.com/pmu-tech/stub-server/tree/test-bin/stub-server

It tests bin/stub-server, to be reviewed and merged after this branch has been merged.

it seems to me that we're testing commander there. The only functional change for me is the fact that we're casting the port from string to a number.

@gko
Copy link
Contributor Author

gko commented Jan 29, 2020

README.md should also be updated: https://github.com/pmu-tech/stub-server/blob/fc83b29b3025d0ff8840fda714fd96a1c54bf781/README.md#command-line

#7

tkrotoff
tkrotoff reviewed Jan 29, 2020
View reviewed changes
bin/stub-server.js Outdated Show resolved Hide resolved
@gko gko requested a review from tkrotoff January 29, 2020 13:22
@tkrotoff tkrotoff merged commit 085da2f into master Jan 29, 2020
@tkrotoff tkrotoff deleted the add_parameters branch January 29, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrotoff tkrotoff tkrotoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make bin/stub-server port and config path configurable
2 participants
@gko @tkrotoff