-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cl-colors2 usage breaking a number of projects? #10
Comments
@xach - I don't maintain cl-colors2. What is the specific problem cl-ansi-text introduced - do you have a test run you could link? |
It's nothing directly to do with cl-ansi-text. The real problem is that cl-colors2's package name conflicts with the existing cl-colors, and some common dependency graphs now include both cl-colors and cl-colors2. For example, a number of projects' test systems depend on prove, and the projects also use the original cl-colors. When the system is loaded, both cl-colors and cl-colors2 load, causing a conflict. Prove's dependence on cl-colors2 comes via cl-ansi-text. I've proposed to cl-colors2 that it rename its package and the systems that require it be updated to use the new name. We'll see how that goes! |
@xach how much pain is this causing the broader ecosystem right now? If it's sufficiently painful, I can back out the cl-color2 change provisionally, and then we can restart work from there. |
Moderate pain. Some test systems are broken. It's early in the release cycle. I think it's better to fix the root cause in cl-colors2 at the moment. Time may change my priorities... |
OK. Looks like Cage has worked on addressing it - - https://notabug.org/cage/cl-colors2/issues/1 give me a heads up if you need me to apply a change. I have no desire to cause pain to ripple out. |
I should also note that Prove is apparently somewhat deprecated in favor of Rove - https://github.com/fukamachi/rove |
Ok, cl-colors2 now has the package |
@xach - sure thing. |
The branch fixes everything for me. |
Oh, and it would be great if it was merged to master. |
I'll release both at the same time. |
Fix #10 - Change package to cl-colors2.
@xach - you're good to go on my end. Please advise if further issues arise! |
Referencing PR #8 and @xach 's comment d9b1ea3#r36624741
@guicho271828 - FYI.
The text was updated successfully, but these errors were encountered: