True color support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @guicho271828 ! Thank you for your contribution! It appears that the docker system used for the unit tests is dead. You might have noticed this library hasn't been updated lately. :) I am in the middle of a big deadline at work; I can try to get the UT fixed tonight or this weekend. edit: whoops, I just noticed that you'd redone the UT system - I added comments and snippet. |
pnathan
reviewed
Dec 13, 2019
pnathan
requested changes
Dec 13, 2019
|
Super cool!
…On Fri, Dec 13, 2019, 6:40 PM Masataro Asai ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#8 (comment)>:
> + matrix:
+ - LISP=sbcl-bin
+ - LISP=ccl-bin
+ - LISP=abcl
+ - LISP=clisp
+ - LISP=ecl
+ - LISP=cmucl
+ - LISP=alisp
+
+matrix:
+ allow_failures:
+ - env: LISP=clisp
+ - env: LISP=abcl
+ - env: LISP=ecl
+ - env: LISP=cmucl
+ - env: LISP=alisp
This uses Allegro CL trial edition
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8?email_source=notifications&email_token=AAFZZYGVUGGJP534RAF6M4LQYRBSVA5CNFSM4J2NRAT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPGNNRA#discussion_r357891942>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFZZYG2AVEC5ZBZM3LBSNTQYRBSVANCNFSM4J2NRATQ>
.
|
|
Done, Thank you for the prompt response. Also, added more comments about the SLIME REPL integration. |
|
ping hope you are not working in the christmas |
pnathan
approved these changes
Dec 29, 2019
|
Awesome! Sorry about the delay. I get distracted. >.> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
true-color (24bit) support, update to cl-colors2, better documentation, better source code organization, testing on more lisps