Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Close compared files" on Cancel #42

Closed
Yaron10 opened this issue Apr 8, 2016 · 4 comments
Closed

"Close compared files" on Cancel #42

Yaron10 opened this issue Apr 8, 2016 · 4 comments

Comments

@Yaron10
Copy link

Yaron10 commented Apr 8, 2016

Hello Pavel,

Continued from #27 (comment).

This makes sense.
However, and with your permission, there's a difference between Match and Cancel:
In the first case we have to display a message box anyway; so why not offer an option to close the files?
In the second case the message box is not necessary.
Good modern applications avoid using message boxes (interrupting the workflow and forcing the user to press OK) if possible.

I hope you agree. :)

Thank you.

BR

@pnedev
Copy link
Owner

pnedev commented Apr 9, 2016

Hello Yaron,

Hm, I don't think it is a good idea to close the files without a prompt in the Cancel case.
Sometimes I have an open file from a project and I want to compare it to a file from another project. I open the second file and compare and if for whatever reason the plugin closes my first file without at least asking that will really piss me off.

I think I'll leave this as it is now.
Thanks.

BR

@pnedev pnedev closed this as completed Apr 9, 2016
@Yaron10
Copy link
Author

Yaron10 commented Apr 9, 2016

Hello Pavel,

This issue's title was not a request but a reference to #27 (comment).
It never occurred to me to suggest closing the files without a prompt. Give me some credit. :) :)
My point was that the message box was not necessary in this case.

Thank you.

BR

@pnedev
Copy link
Owner

pnedev commented Apr 9, 2016

Hello Yaron,

I didn't mean to sound harsh if that's what you felt.
I really value your opinion and feedback. Thanks.
I guess it's just another misunderstanding :)

BR

@Yaron10
Copy link
Author

Yaron10 commented Apr 10, 2016

Hello Pavel,

Thank you. I appreciate your kindness.
I actually found this misunderstanding quite funny. "Give me some credit." was written with a wink. :)

BR

pnedev added a commit that referenced this issue Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants