-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling Reset() after compared files have been closed #27
Comments
Hello Yaron,
I haven't actually, thanks for pointing this out. BR |
Hello Pavel, Thanks again for your remarkable work. BR |
Hello Yaron, This is not relevant anymore due to the new implementation so I'm closing this issue. One question: BR |
Hello Pavel,
Great. 👍 BR |
Hello Pavel,
I've tried to zoom in a bit (i.e. I've taken a second look at some parts of Compare.cpp) and found that Reset() is called if the user selects to close both compared-matched files.
It seems that some parts of Reset() are irrelevant in this case.
(Actually , this is true even if the files do not match and the user closes one or both).
I assume you've already noticed that. Just in case. :)
Thank you very much.
Best regards.
The text was updated successfully, but these errors were encountered: