Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
  • Loading branch information
pnkfelix and bjorn3 committed May 14, 2020
1 parent bcaecd1 commit 34a1a2d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions tests/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ use self::meta_build::{DeltaKind, InjectionPoint, Test, YearMonthDay};
use self::which_temp::{WhichTempDir, WhichTempDirectory};

// These tests pass `--preserve` and `--access=github` because that is the best
// way to try to enusre that the tests complete as quickly as possible.
// way to try to ensure that the tests complete as quickly as possible.

pub const BASIC_TEST: Test = Test {
crate_name: "cbr_test_cli_basic",
Expand All @@ -46,7 +46,7 @@ pub const FIXED_TEST: Test = Test {
delta_kind: DeltaKind::Fix,
};

// Ordnarily, I would put both of these tests into separate `#[test]` methods.
// Ordinarily, I would put both of these tests into separate `#[test]` methods.
// However, if you do that, then `cargo test` will run them in parallel, and you
// end up with `cargo-bisect-rustc` racing to install the toolchains it
// downloads.
Expand Down Expand Up @@ -83,7 +83,7 @@ where WhichTemp: WhichTempDirectory
println!("Command output stderr for {}: \n```\n{}\n```", test.crate_name, stderr);

// The most basic check: does the output actually tell us about the
// "reressing" commit.
// "regressing" commit.
let needle = format!("regression in {}", test.expected_sha());
// println!("searching for {:?} in stdout: {:?} stderr: {:?}", needle, stdout, stderr);
assert!(stderr.contains(&needle));
Expand Down
2 changes: 1 addition & 1 deletion tests/cli/meta_build/included_build_suffix.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Strategy inspired by dtolnay/rustversion: run `rustc --version` at build time
// to observe verison info.
// to observe version info.
//
// (The dtolnay/rustversion is dual-licensed under APACHE/MIT as of January 2020.)

Expand Down
4 changes: 2 additions & 2 deletions tests/ice.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const ICE_MAIN_RS: &'static str = std::include_str!("ice/included_main.rs");
//
// In the long term, since we only store binaries over a fixed length of time,
// this test will need to be updated with new examples of ICE's. (For now it
// seems safe to assume thqt the compiler will always have *some* example
// seems safe to assume that the compiler will always have *some* example
// program that can be used to observe an ICE.)

const CARGO_TOML: &'static str = r##"
Expand Down Expand Up @@ -76,7 +76,7 @@ where WhichTemp: WhichTempDirectory
println!("Command output stderr for {}: \n```\n{}\n```", CRATE_NAME, stderr);

// The most basic check: does the output actually tell us about the
// "reressing" commit.
// "regressing" commit.
let needle = format!("regression in {}", INJECTION_COMMIT);
// println!("searching for {:?} in stdout: {:?} stderr: {:?}", needle, stdout, stderr);
assert!(stderr.contains(&needle));
Expand Down

0 comments on commit 34a1a2d

Please sign in to comment.