Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension fail to build on windows #8

Closed
jcfr opened this issue Sep 5, 2013 · 10 comments
Closed

Extension fail to build on windows #8

jcfr opened this issue Sep 5, 2013 · 10 comments

Comments

@jcfr
Copy link
Contributor

jcfr commented Sep 5, 2013

See http://slicer.cdash.org/buildSummary.php?buildid=150036

After fixing the issue(s), make sure to regenerate the corresponding extension description file and submit a pull request against both master [1] and 4.3 [2] branch on the extensionsindex.

[ Also notifying @pieper of this issue ]

[1] http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/Contribute_Extension_Description_File#Extensions_build_against_Slicer_trunk_2

[2] http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/Contribute_Extension_Description_File#Extensions_build_against_Slicer_4.3_2

@pieper
Copy link
Contributor

pieper commented Sep 6, 2013

Hi Ryan -

Let me know if you need help with this.

Best,
Steve

On Thu, Sep 5, 2013 at 7:51 PM, Jean-Christophe Fillion-Robin <
notifications@github.com> wrote:

See http://slicer.cdash.org/buildSummary.php?buildid=150036

After fixing the issue(s), make sure to regenerate the corresponding
extension description file and submit a pull request against both master
[1] and 4.3 [2] branch on the extensionsindex.

[ Also notifying @pieper https://github.com/pieper of this issue ]

[1]
http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/Contribute_Extension_Description_File#Extensions_build_against_Slicer_trunk_2

[2]
http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/Contribute_Extension_Description_File#Extensions_build_against_Slicer_4.3_2


Reply to this email directly or view it on GitHubhttps://github.com//issues/8
.

@ihnorton
Copy link
Contributor

ihnorton commented Oct 6, 2016

@jcfr can you please enable the extension for the Windows nightly? The Win build issues should be fixed now, mostly thanks to VS2013 (fixing Eigen issues), plus a few small updates (8cde8e6). It doesn't seem to be built by factory-south-win7.kitware, and I'm not sure where the exclusion list is maintained.

@jcfr
Copy link
Contributor Author

jcfr commented Oct 6, 2016

@ihnorton
Copy link
Contributor

ihnorton commented Oct 7, 2016

Any luck? Doesn't seem to have run last night either, and as far as I can tell the other extensions finished already 2+ hours ago on factory-south-win7.kitware.

@jcfr
Copy link
Contributor Author

jcfr commented Oct 7, 2016

Looking at the factory, their are updates happening in the terminal where the nightly script is running.

That said, there are two other things I can observe and report:

  • SlicerApp-real.exe crashed and is waiting for user to click on "close the program". I looked in the past how to avoid this type of windows but didn't come up with a working solution. Do you know how to avoid them ?
  • One of the Reporting extension test is waiting for user input to create a DICOM database. This is blocking.

I don't know if only one or both of these are related to the Nightly build but I suspect this is preventing the Nightly build (or part of it) from going forward ...

screenshot from 2016-10-07 09-36-50

@jcfr
Copy link
Contributor Author

jcfr commented Oct 7, 2016

The blocking popup with the DICOM database is now gone .. but this type of things delay the all build until ctest timeout on a particular test

@ihnorton
Copy link
Contributor

ihnorton commented Oct 7, 2016

Ah, some other extension/test is hanging and it doesn't even get to UKF?

SlicerApp-real.exe crashed and is waiting for user to click on "close the program". I looked in the past how to avoid this type of windows but didn't come up with a working solution. Do you know how to avoid them ?

Looks like could set a registry key, [HKLM|HKCU]\Software\Microsoft\Windows\Windows Error Reporting\DontShowUI to 1. See http://stackoverflow.com/questions/3561545/how-to-terminate-a-program-when-it-crashes-which-should-just-fail-a-unit-test/3637710#3637710

@jcfr
Copy link
Contributor Author

jcfr commented Oct 7, 2016

Two more comments:

  • DontShowUI

It was set to 0,

screenshot from 2016-10-07 09-57-25

I just updated it to be one.

screenshot from 2016-10-07 10-00-02

  • Given the implementation of the windows nightly script, nightly build for 4.5 will happen. Error of previous step are ignored. This is good and it explains why the 4.5 is happening. I will improve the script to log when a step has completed. That way we will now if one is blocking.

@ihnorton
Copy link
Contributor

ihnorton commented Oct 7, 2016

nightly build for 4.5 will happen.

I don't expect it ever to work on 4.5/Windows, because the related Eigen version can't be built on VS2008. Just want to get it going to current trunk and next release.

@ihnorton
Copy link
Contributor

UKF is now available on Windows, as of 3/17 nightly build. (cc @ljod)

Ref: commits to ExtensionsIndex and UKF to eliminate the Eigen(Slicer extension) dependency and instead download Eigen directly (fixes this issue as well as other extension packaging/installation issues on several platforms).

ukf-windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants