Verifications for Section 5.16.2 of ASHRAE Guideline 36 #3
Conversation
… with airflow tracking.
…with airflow tracking.
…with airflow tracking.
| on: | ||
| push: | ||
| branches: [ develop ] | ||
| pull_request: | ||
| branches: [ '*' ] |
There was a problem hiding this comment.
Changed the workflow so we only build the doc when we push on develop and/or we create a PR.
| branches: [ develop ] | ||
| branches: [ '*' ] |
There was a problem hiding this comment.
Changed the workflow so we run the tests on all pushes.
| else: | ||
| return False | ||
| else: | ||
| return "Untested" |
There was a problem hiding this comment.
I see what you mean in the comments of my PR. My only concern with this is if "Untested" will trigger a error with matplotlib trying to plot the time series. Other than that, as long as we follow the rule, either way should be okay.
| return False | ||
| else: | ||
| if len(self.result[self.result == "Untested"] > 0): | ||
| return "Untested" |
There was a problem hiding this comment.
is it only "Untested" if all samples are "Untested", or as long as one sample is "Untested"? I thought it should be the former. Maybe it depends. I modified check_bool in checklib.py in PR #4 to implement the former.
| def verify(self): | ||
| self.result = self.df.apply(lambda d: self.relief_air_damper(d), axis=1) | ||
|
|
||
| def check_bool(self): |
There was a problem hiding this comment.
this check_bool is already implemented in RuleCheckBase. Applies to similar locations elsewhere
| return False | ||
| else: | ||
| if len(self.result[self.result == "Untested"] > 0): | ||
| return "Untested" |
There was a problem hiding this comment.
similar to an earlier comment. We may also want to test this. This is optional, just for you to consider.
schema/library.json
Outdated
| @@ -532,5 +532,291 @@ | |||
| ], | |||
| "description_verification_type": "rule-based", | |||
| "assertions_type": "pass" | |||
| } | |||
| }, | |||
| "G36_SupplyAirTemperatureSetpoint": { | |||
There was a problem hiding this comment.
@leijerry888 FYI, Jeremy and I discussed that the names should match the class names. Also, as of G36_SimultaneousHeatingCooling, there are 2 more spaces so, this will be fixed soon.
There was a problem hiding this comment.
Fixed in the latest commit!
Verifications for Section 5.16.2, Supply Air Temperature, of ASHRAE Guideline 36.