This repository has been archived by the owner on Jan 19, 2021. It is now read-only.
Fixed timeouts on Get-PnPSiteCollectionAdmin #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed timeouts on Get-PnPSiteCollectionAdmin on site collections with many users.
KoenZomers
added
the
status:checked and ready for merge ✔
|
Thanks @MrTantum ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
N/A
What is in this Pull Request ?
Fixed timeouts when using
Get-PnPSiteCollectionAdminon site collections with many users. The old logic loaded all users of the site and filtered afterwards. The new logic includes the filter in the query itself.The same problem will occur when using
GetAdministratorsfrom SecurityExtensions in PnP-Sites-Core. This will need an additional fix.