-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement twitter cards #124
Comments
I'll pick this one up, for future reference: Remove the following snippet to fall back to custom implementation blog/themes/reader-hugo/layouts/partials/head.html Lines 77 to 78 in 1c05096
Rewrite to use correct image (currently using the svg logo) blog/themes/reader-hugo/layouts/partials/head.html Lines 46 to 75 in 1c05096
|
hey @appieschot can you please only change the files in the blog/layouts folder and not in the blogs/themes/reader-hugo/layouts folder? This way we don't override the theme. This was @hugoabernier s suggestion :-) |
Will look into it, we should be able to do I think 🦾 |
@hugoabernier do you want me to revert #127 and implement a custom file in the |
that would be perfect! |
Implemented correct twitter image. Solves #124
Implemented correct twitter image. Solves #124
Solved with last PR, cards should be visible now. |
Implemented correct twitter image. Solves pnp#124
Implemented correct twitter image. Solves pnp#124
Article issue
The template currently does not render the header image when posting a link to twitter. We should update our template to provide the required OpenGraph or Twitter info to render images propperly.
We can use https://cards-dev.twitter.com/validator to validate our current template.
The text was updated successfully, but these errors were encountered: