Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: m365 spo page clientsidewebpart add removes all previously set settings on the page #2068

Closed
estruyf opened this issue Jan 13, 2021 · 1 comment
Closed

Bug report: m365 spo page clientsidewebpart add removes all previously set settings on the page #2068

estruyf opened this issue Jan 13, 2021 · 1 comment
Assignees
@estruyf
Labels
bug work in progress
Milestone
v3.5

Comments

@estruyf
Copy link
Member

estruyf commented Jan 13, 2021

Description

When adding a new web part to a page, it removes all previously set properties like topic header, description, ...

Steps to reproduce

  • Create a page
  • Add a page description
  • Run the m365 spo page clientsidewebpart add command and you'll notice that description is gone

Expected result

Previously set properties should not be removed.

You can assign it to me.
@waldekmastykarz
Copy link
Member

Good find and thank you for your help ❤️

estruyf added a commit to estruyf/cli-microsoft365 that referenced this issue Jan 14, 2021
@estruyf
pnp#2068 pnp#2069 - Leave all previous values in place + check in the…
ab6d530 
… page at the end
@estruyf estruyf mentioned this issue Jan 14, 2021
Closed
@waldekmastykarz waldekmastykarz added this to the v3.5 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estruyf estruyf

Labels
bug work in progress
Projects
None yet
Milestone
v3.5
Development

No branches or pull requests
2 participants
@estruyf @waldekmastykarz