Extend aad app set to add certificate to already available App

[arjunumenon]

Create the option of adding the certificate to already available Azure AD App using the command aad app set.
Following would be the expected options for the command.

Option	Description
--certificateFile [certificateFile]	Path to the file with certificate private key. Specify either certificateFile or certificateBase64Encoded
--certificateBase64Encoded [certificateBase64Encoded]	Base64-encoded string with certificate private key. Specify either certificateFile or certificateBase64Encoded
--certificateDisplayName [certificateDisplayName]	Display name for the certificate. If not given, the displayName will be set to the certificate subject

[martinlingstuyl]

Hi guys, I like this one, you can assign me here!

[arjunumenon]

Thanks @martinlingstuyl for your help.
All yours!!

[martinlingstuyl]

Hi @arjunumenon,

would it be an idea to add an extra option: --certificateDisplayName?

Using the displayName property on the Microsoft Graph AAD app update call is optional. If not filled in, the displayName will be set to the certificate subject.
In my case it became something like: CN=Test Certificate for CLI

[waldekmastykarz]

Makes perfect sense @martinlingstuyl. Great suggestion! 👏

[arjunumenon]

Wonderful suggestion @martinlingstuyl 👍. I have updated the spec for the same.

I have also updated the spec for #3115 which also deals with the similar enhancement

[martinlingstuyl]

Fantastic, I'm already working on it. Expect a pull request in a few days!

[martinlingstuyl]

A small thing. The specs speak about a private key, but I assume you mean public key...

[martinlingstuyl]

Hi guys, is it acceptable if I close #3115 and #3116 in a single PR?

[waldekmastykarz]

Hi guys, is it acceptable if I close #3115 and #3116 in a single PR?

Yes, but please keep the commits separate so that it's clear which changes apply where.

[martinlingstuyl]

By the way, I'm not replacing the certificate. I'm adding it to the list of available certificates. Seems to me the best route, as you would want to have some form of fallback to use the older certificates if they are referenced somewhere.

[waldekmastykarz]

That's definitely the right approach: let's not replace whatever is in there but rather add another certificate

[martinlingstuyl]

This can be closed now