Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sample script: uninstall package script #3904

Closed
4 tasks
Adam-it opened this issue Oct 24, 2022 · 6 comments
Closed
4 tasks

New sample script: uninstall package script #3904

Adam-it opened this issue Oct 24, 2022 · 6 comments

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Oct 24, 2022

Docs
Author Waldek Mastykarz
Original Post #1961
Description scripts allowing developers to easily uninstall .sppkg packages in their tenant, used during development after running gulp package-solution
Keywords spfx sharepoint

the script should have the following steps:

  • automatically detects the package to remove based on the project structure (script assumes it's located in the project root)
  • retracts the package from the tenant
  • removes the package from app catalog
  • removes the package from recycle bin (unless removing from app catalog already gets rid of the file outside of recycle bin)
@Adam-it Adam-it added good first issue docs hacktoberfest Issue perfect for hacktoberfest labels Oct 24, 2022
@Jwaegebaert Jwaegebaert removed the hacktoberfest Issue perfect for hacktoberfest label Nov 2, 2022
@Saurabh7019
Copy link
Contributor

Hi, Can I work on this? It would be my first script contribution.

@milanholemans
Copy link
Contributor

Certainly @Saurabh7019!

Just want to say that we will have a code freeze starting Wednesday for our new monthly release. Although normally this isn't too bad for a sample script, we are also planning to move to a new site generator. This means that you probably will get some merge conflicts when we move because the new site generator uses some different syntaxes etc.
Although I think the amount of merge conflicts won't be too bad for a sample script. I just wanted to let you know 😊

@Saurabh7019
Copy link
Contributor

Hi Milan, will the code freeze and site generator move affect the ongoing pull requests?

@milanholemans
Copy link
Contributor

milanholemans commented May 23, 2023

Hi Milan, will the code freeze and site generator move affect the ongoing pull requests?

Code freeze doesn't affect it. One week before a release we try to avoid merging PRs (apart from docs PRs) so we don't introduce last-minute bugs in the tool. After the release, we can start merging PRs again.

The move to another site generator will affect quite a few PRs indeed. Nearly all PRs that change documentation will break, unfortunately. We'll try to merge as many PRs as possible to reduce merge conflicts.
We're moving from Mkdocs to Docusaurus, and these generators use different syntaxes, but for a sample script, you won't get that many merge conflicts.

@Saurabh7019
Copy link
Contributor

Thanks for the clarification. I have one open PR for docs. Please let me know if any changes are needed before merging.

@milanholemans
Copy link
Contributor

Thanks for the clarification. I have one open PR for docs. Please let me know if any changes are needed before merging.

We labeled all docs PRs with the pr-priority label. These PRs will be merged before the change, so nothing to worry about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants