New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update response of flow run list
#4444
Comments
Opening this up as we are releasing v7 after the summer holidays. Warmly recommended for your contribution. 🎉 |
🙋♂️ |
milanholemans
pushed a commit
that referenced
this issue
Jul 29, 2023
milanholemans
pushed a commit
that referenced
this issue
Aug 6, 2023
waldekmastykarz
pushed a commit
that referenced
this issue
Aug 12, 2023
milanholemans
pushed a commit
that referenced
this issue
Aug 12, 2023
Adam-it
pushed a commit
that referenced
this issue
Aug 16, 2023
waldekmastykarz
pushed a commit
that referenced
this issue
Aug 19, 2023
waldekmastykarz
pushed a commit
that referenced
this issue
Aug 26, 2023
Jwaegebaert
pushed a commit
that referenced
this issue
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Was checking the command
flow run list
and noticed 2 things that are not quite optimal.Noticed that the command
flow run list
is modifying the result. We copy the startTime and status to another place in the result. This for the simple reason that these are defaultProperties and thus won't work when they are in a nested object. According to me it's quite pointless to have 2 the same properties in the result.Therefore I suggest that we perform an output check, and if we should modify the output (text, csv), that we return a custom response with all defaultProperties in it. If this is not the case, just return the original result
We only log the result if we get at least 1 flow run returned. If there are no runs returned, we simply log an error and that's it.
According to me, if there were no flow runs found, we should just log an empty array and that's it, it's quite hard to use this command in a script if it can return either an array or an error.
The code right now:
cli-microsoft365/src/m365/flow/commands/run/run-list.ts
Lines 56 to 68 in 97d58e0
Update:
Same goes for following commands:
The text was updated successfully, but these errors were encountered: