Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance flow run list, flow environment get and flow environment list output #5349

Closed

Conversation

MathijsVerbeeck
Copy link
Contributor

Closes #4444

@milanholemans milanholemans linked an issue Jul 25, 2023 that may be closed by this pull request
@milanholemans
Copy link
Contributor

Thank you @MathijsVerbeeck, we'll try to review it ASAP!

@milanholemans milanholemans added the pr-major PR for the next major release label Jul 25, 2023
@milanholemans
Copy link
Contributor

Hi, @MathijsVerbeeck thank you for contributing to the next major release. Since this is a breaking change, could you please extend our v7 upgrade guidance with this breaking change?

Much appreciated! 🙏

@milanholemans milanholemans marked this pull request as draft July 26, 2023 23:19
@MathijsVerbeeck MathijsVerbeeck marked this pull request as ready for review July 27, 2023 09:52
@MathijsVerbeeck MathijsVerbeeck changed the title Enhance flow run list output Enhance flow run list, flow environment get and flow environment list output Jul 27, 2023
@milanholemans milanholemans self-assigned this Jul 29, 2023
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the extra work! Made few changes while merging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the docs as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the docs as well.

@@ -26,6 +26,22 @@ In version 6 of the CLI for Microsoft 365, for setting the list commandset, you

Since the option `id` was mandatory in V6 and if your scripts are dependent on the default mandatory error output which the command would return, you may have to update your scripts accordingly.

## Enhanced `flow run list` and `flow environment list` output

In version 7 of the CLI for Microsoft 365, we have made an enhancement for the data returned by the `flow run list` and `flow environment list` commands. Currently, when no items were found, we would only log an output when `--verbose` was specified. This made this command very unpredictable to use in scripts. This has now been changed so an empty array will be logged when no items were found. Also, when specifying `--output json`, we would have duplicate properties in the result. These properties have been removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of currently we should use previously because we are talking about the previous version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged your two sections into one.

@milanholemans
Copy link
Contributor

Merged manually, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-major PR for the next major release pr-merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update response of flow run list
2 participants