Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added findFile functionality to Web, List, Folder #818

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

dennisvanniel
Copy link
Contributor

Added functionality I needed for finding files in Web, List, or Folder, with optional use of wildcard (*) for matching partial filenames. It's modelled after the Find-PnpFile cmdlet in PnP PowerShell.

Haven't posted a message in the issue list first as I should have done (as I see now in the contributing guidelines)
No documentation written, though I shall write if you choose to accept these extensions.

Added functionality for finding files in Web, List, or Folder, with optional use of wildcard (*) for matching partial filenames.
@dennisvanniel dennisvanniel marked this pull request as ready for review April 9, 2022 12:43
@jansenbe
Copy link
Contributor

jansenbe commented Apr 9, 2022

Nice work @dennisvanniel ! Looks like a good addition, I'll take a closer look as of the 19th as I'm OOF currently. Maybe I can process this before that date, but just wanted to set expectations.

@jansenbe jansenbe self-assigned this Apr 9, 2022
@jansenbe jansenbe added the area: model 📐 Related to the core SDK models label Apr 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #818 (83a12f3) into dev (63545f3) will increase coverage by 1.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #818      +/-   ##
==========================================
+ Coverage   82.42%   83.45%   +1.03%     
==========================================
  Files         416      479      +63     
  Lines       28590    33354    +4764     
==========================================
+ Hits        23565    27836    +4271     
- Misses       5025     5518     +493     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
....Core/Exceptions/MicrosoftGraphServiceException.cs 80.00% <0.00%> (-20.00%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 54.94% <0.00%> (-12.96%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 87.67% <0.00%> (-12.33%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
...e/Model/SharePoint/Core/Internal/ListCollection.cs 82.12% <0.00%> (-9.09%) ⬇️
...P.Core/Services/Core/CSOM/Utils/CSOMFieldHelper.cs 80.61% <0.00%> (-7.81%) ⬇️
... and 143 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db135c5...83a12f3. Read the comment docs.

jansenbe added a commit that referenced this pull request Apr 25, 2022
@jansenbe jansenbe merged commit c5392ae into pnp:dev Apr 25, 2022
@jansenbe
Copy link
Contributor

Hi @dennisvanniel , I've today merged your PR, nice job 💪🚀. There's one change I did and that's removing the find files option in IWeb as that possible extremely slow as it runs over each folder (also the ones without a list associated). Users can still trigger this behavior via the IWeb's RootFolder, but it's best to that a user only uses this feature on a given folder or list.

Would be good if you could add some basic documentation for this, if not possible then let me know so I can create an issue to track this for the future. Thanks :-)

@dennisvanniel
Copy link
Contributor Author

Hi @jansenbe,
I'll write some basic documentation. Should be finished by the end of next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: model 📐 Related to the core SDK models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants