Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamics 365 CE online plugin error #458

Closed
1 task done
TkachouAndrej opened this issue Sep 11, 2021 · 9 comments
Closed
1 task done

Dynamics 365 CE online plugin error #458

TkachouAndrej opened this issue Sep 11, 2021 · 9 comments
Assignees

Comments

@TkachouAndrej
Copy link

Category

  • Bug

Describe the bug

Trying to use PnP framework (PnP.Core, PnP.Core.Auth) in D365 CE online plugin, faced with issue:

  1. Sign my custom assembly and rebuild the project.
  2. See warnings:
    Referenced assembly 'PnP.Core, Version=1.3.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.
    Referenced assembly 'PnP.Core.Auth, Version=1.3.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.
  3. Try to run my custom assembly in debug mode via the plugin registration tool and see error:
    Could not load file or assembly 'PnP.Core, Version=1.3.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. > A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)
  4. Unsign my custom assembly and rebuild the project - no warnings. But we can't use unsigned assemblies as plugins.

Steps to reproduce

Sign PnP assemblies with strong key.

Expected behavior

Custom signed assembly could be used as CRM plugin.

Attachments

Visual studio 2017 warnings :

1

Plugin registration tool error :

2

Environment details (development & target environment)

  • SDK version: [1.3.0]
  • OS: [Windows 10]
  • SDK used in: [.NET Assembly]
  • Framework: [.NET Framework 4.6.1]
  • Tooling: [Visual Studio 2017, Plugin Registration Tool]
@jansenbe jansenbe self-assigned this Sep 11, 2021
@jansenbe
Copy link
Contributor

Let me evaluate the options here @TkachouAndrej

@jansenbe
Copy link
Contributor

@TkachouAndrej : I'm working on strong naming the assemblies, plan to finish today that work today so that you can test again with tomorrow's nightly build. Thanks for bringing this up.

jansenbe referenced this issue in pnp/pnpcore Sep 14, 2021
…rnals are not exposed anymore to libraries outside of the PnP Core SDK solution
@jansenbe
Copy link
Contributor

@TkachouAndrej : version 1.3.52 and all future ones are strong named, so now you should be able to include the PnP Core SDK in your work.

@TkachouAndrej
Copy link
Author

@jansenbe, when are you going to release 1.3.52? I can find only old 1.3.0 version in NuGet now. Thank you.

@jansenbe
Copy link
Contributor

You need to allow preview versions to be used when querying nuget packages from visual studio or other IDEs

@TkachouAndrej
Copy link
Author

@jansenbe, sorry, but I forgot to add PnP.Framework: the same issue

Снимок экрана 2021-09-15 в 19 40 02

@jansenbe jansenbe reopened this Sep 15, 2021
@jansenbe
Copy link
Contributor

For PnP Framework the situation is more complex as it today uses a non strong names dependency... That would have to be remediated first. Do you have a hard dependency on PnP Framework?

@jansenbe
Copy link
Contributor

Let's move this issue to the PnP Framework repo as that's what needs to be changed

@jansenbe jansenbe transferred this issue from pnp/pnpcore Sep 16, 2021
@jansenbe
Copy link
Contributor

@TkachouAndrej : the next nightly build of PnP Framework will be strong named

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants