Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing HeaderLayoutType #498

Closed
Bux42 opened this issue Oct 14, 2021 · 1 comment · Fixed by #562
Closed

Missing HeaderLayoutType #498

Bux42 opened this issue Oct 14, 2021 · 1 comment · Fixed by #562
Assignees
@jansenbe

Comments

@Bux42
Copy link

Bux42 commented Oct 14, 2021

Hello,

There are two out out of four HeaderLayoutTypes being handled in those switch statements:

pnpframework/src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectSiteHeaderSettings.cs

Line 27 in ac4dc39

switch (web.HeaderLayout)

pnpframework/src/lib/PnP.Framework/Provisioning/ObjectHandlers/ObjectSiteHeaderSettings.cs

Line 60 in ac4dc39

switch (template.Header.Layout)

"Extended" and "Minimal" (already present in HeaderLayoutTypes enum) are missing from those two switches

Could you add those?

Thanks in advance!
@jansenbe jansenbe self-assigned this Dec 2, 2021
jansenbe added a commit that referenced this issue Dec 2, 2021
@jansenbe
Missing HeaderLayoutType implemented #498
4e10ec6
@jansenbe
Copy link
Contributor

jansenbe commented Dec 2, 2021

Nice catch @Bux42 . I've just pushed a fix for this, please test with the next nightly and re-open the issue if the problem still persists.

@jansenbe jansenbe closed this as completed Dec 2, 2021
fzbm added a commit to fzbm/pnpframework that referenced this issue Jan 3, 2022
@fzbm
Additional changes for fix pnp#498
e59e15e 
The previously made changes for fix pnp#498 were missing changes required
for provisioning the header information.

Additional changes:

* Removed case for "HeaderLayoutType.Standard" in "ExtractObjects",
  because "default" already handles this.
* Removed "scope" variable, because it is not used.
* Removed the "Emphasis" type reference from "Enum.TryParse", because
  the "out" variable already specifies the type.
* "ProvisionObjects" now exits as soon as possible if no changes are
  required. This also moves a possible server call for loading the web
  URL to a state, were this information would be required.
* Introduced some (single) blank lines to increase the readability of
  the code.
@fzbm fzbm mentioned this issue Jan 3, 2022
Merged
czullu pushed a commit to MondayCoffee/pnpframework that referenced this issue Jan 7, 2022
aligned with pnp#498 / pnp#562 but includes HideTitleInHeader as well
0065468
@czullu czullu mentioned this issue Jan 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansenbe jansenbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Additional changes for fix #498 fzbm/pnpframework
2 participants
@jansenbe @Bux42