Fix conversion between PnPCore enum values and PnP.Framework enums #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a conversion between PnPCore enum values and PnP.Framework enums. The old code does a C-style cast from the PnPCore enum to the PnP.Framework one but the 2 enums have the possible values defined in different order:
PnPCore:
PnP.Framework:
This means PageHeaderTitleAlignment.Left with value 1 gets converted to ClientSidePageHeaderTextAlignment of value 1, so ClientSidePageHeaderTextAlignment.Center .
The current code already tries to convert from an enum to another through .ToString() but parses it back to PnPCore enum instead of PnP.Framework.
To compare the old and the new code:
While at it I updated 2 other similar fields
Type
andLayoutType
that never showed any issue because the enums are defined in the same order in both projects.In addition to this it might be worth to consider having the 2 enums with the same order in both projects.
Fix #266