Fix Access Denied error when processing <pnp:SiteSettings> object #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an Access Denied error when processing pnp:SiteSettings object caused by ExecuteQuery() calls triggered by helper methods (like site.IsCommunicationSite()) executed on the wrong Context object.
By manually calling ExecuteQuery() right away, we ensure the updated settings are sent using the correct Context object. As many of the helper methods like site.IsCommunicationSite() already trigger ExecuteQuery() calls, it kind of makes the whole
isDirtypattern useless as it gives the false impression that only 1 call at the end will be made as a single point where the updated settings are sent, while in fact it can happen before too.This issue fixes #357 , see the long troubleshooting at #357 (comment)