Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration settings for SharePoint tab entity inside Teams #385

Merged

Conversation

roberAlb
Copy link

Configuration for SharePoint tab was empty. Basically, we have detected an issue trying to use de Website tab with a SharePoint site collection url, it works but all links inside that page loaded from the tab are not working. We have checked that they work if the tab is a SharePoint tab.

@luismanez
Copy link

Hitting this issue too. When we provision a Website Tab in a Team, pointing to a SP site using PnP Framework, all the links in the page that points to an "internal" url (tenant.sharepoint.com/...) are not working (curisously, links pointing to external sites, work fine).
Please @jansenbe could you have a look to this PR?

Here is the template part that provisions the Website teams tab pointing to a SP Site:

      <pnp:Channels>      
        <pnp:Channel DisplayName="General" Description="" IsFavoriteByDefault="true">
          <pnp:Tabs>
            <pnp:Tab DisplayName="Wiki" TeamsAppId="" Remove="true" />
            <pnp:Tab DisplayName="Home" TeamsAppId="com.microsoft.teamspace.tab.web">
              <pnp:Configuration EntityId="" ContentUrl="https://tenant.sharepoint.com/sites/marketing" RemoveUrl="" WebsiteUrl="https://tenant.sharepoint.com/sites/marketing" />
            </pnp:Tab>
          </pnp:Tabs>
        </pnp:Channel>
      </pnp:Channels>

Many thanks.

@jansenbe jansenbe self-assigned this Jul 2, 2021
@jansenbe
Copy link
Contributor

jansenbe commented Jul 2, 2021

Good fix, thanks @roberAlb and @luismanez

jansenbe added a commit that referenced this pull request Jul 2, 2021
@jansenbe jansenbe merged commit f291d34 into pnp:dev Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants