Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 390 fixed in CreateOrUpdateTeamFromGroupInternal. #391

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

luismanez
Copy link

Now the existing retry code will work as expected. When the CreateOrUpdateTeamFromGroupInternal calls the GraphHelper

teamId = GraphHelper.CreateOrUpdateGraphObject(.....)

If the returned teamId is null or empty, the existing retry code will be hit. The wait variable is set to false only in the teamId is not null

if (!string.IsNullOrEmpty(teamId))
{
    wait = false;
}

@jansenbe jansenbe self-assigned this Jul 2, 2021
@jansenbe
Copy link
Contributor

jansenbe commented Jul 2, 2021

Good catch @luismanez , thanks for sharing the fix!

@jansenbe jansenbe merged commit aa82a77 into pnp:dev Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants